linux-kernel - Re: [PATCH 1/2] pinctrl: correct a offset while enumerating pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYTeaWRKk2bhhGypLbS4sfq8eNNe-KFukfXS7RmDpZt0Q@mail.gmail.com>
Date:	Wed, 4 Jan 2012 10:37:42 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Chanho Park <chanho61.park@...sung.com>
Cc:	swarren@...dia.com, Baohua.Song@....com,
	linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH 1/2] pinctrl: correct a offset while enumerating pins

On Tue, Jan 3, 2012 at 9:37 AM, Chanho Park <chanho61.park@...sung.com> wrote:
>> From: Linus Walleij [mailto:linus.walleij@...aro.org]
>> On Tue, Jan 3, 2012 at 8:47 AM, Chanho Park <chanho61.park@...sung.com>
>> This:
>>
>> > -               /* Pin space may be sparse */
>> > +               /* Skip if we cannot search the pin */
>> (...)
>> > -               /* Pin space may be sparse */
>> > +               /* Skip if we cannot search the pin */
>>
>> I don't see why you're changing that comment, it is still true that
>> the pin space may be sparse and that is what your patch confirms.
>>
>> So I will restore that comment...
>
> We do not concern that pin space is sparse
> because we enumerate the pin space using the offset of array.
> This situation is that we cannot search the pin from radix tree.
> It is BUGON() or just skip this pin :)

Yes but the comment there is about why we are searching
the radix tree instead of just inserting the new pin. If the
radix tree was not sparse, we would not need to search
it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/