linux-kernel - Re: [PATCH v1 0/3] Tegra30 clockframework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120104122817.GI32619@tbergstrom-lnx.Nvidia.com>
Date:	Wed, 4 Jan 2012 14:28:17 +0200
From:	Peter De Schrijver <pdeschrijver@...dia.com>
To:	Stephen Warren <swarren@...dia.com>
CC:	Colin Cross <ccross@...roid.com>, Olof Johansson <olof@...om.net>,
	"Russell King" <linux@....linux.org.uk>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 0/3] Tegra30 clockframework

On Wed, Jan 04, 2012 at 12:03:30AM +0100, Stephen Warren wrote:
> Peter De Schrijver wrote at Monday, January 02, 2012 8:18 AM:
> > This patchset introduces the tegra30 clockframework. Clocks which require
> > voltage scaling are not included in this version. The implementation doesn't
> > use the generic clock code yet. It's the intention to move to it, once the
> > semantics are fully clarified.
> 
> I'm not particularly familiar with Tegra's clocks, but nothing really
> stood out as wrong with this patch on a quick look-through. It'd be great
> if someone like Colin could look this over.
> 
> A couple thoughts below. You've probably thought about some of these
> already, but I just wanted to make sure:-)
> 
> * Are we following the common clock stuff so we can move over once it's
> ready?
> 

I think we can use the same approach then OMAP4 to convert this to the common
clock stuff.

> * Are Tegra20 and Tegra30 so different we can't re-use any of the code
> in tegra2_clocks.c for Tegra30?
> 

Apart from some small functions (such as clk_measure_input_freq()), it's not
easy to share code between both.

> * The device names in the peripheral clock table might benefit from a
> review to make sure they match tegra2_clocks.c for the drivers we've
> actually upstreamed at least.

Good point. I should check that...

Cheers,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/