linux-kernel - Re: [PATCH] power_supply: add "unknown" in power supply type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120104045150.GA1039@oksana.dev.rtsoft.ru>
Date:	Wed, 4 Jan 2012 08:51:50 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>
Subject: Re: [PATCH] power_supply: add "unknown" in power supply type

On Wed, Nov 30, 2011 at 11:08:33PM -0800, Kim, Milo wrote:
> Hi, Anton
> 
> For the default value of power supply type, "unknown" is added.
> With default prop value, supply type property can be displayed as default - "Unknown".

Applied, thanks!

> And union propval is set to zero.
> Then no data abort exception even if the propval is not updated by xxx_get_property().

Why it is not updated in the first place (assuming get_property() returned
success)?.. Driver should be fixed then... I dropped this change.

In any case, if we want this change, it should be a separate patch.

Thanks!

> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
> ---
>  drivers/power/power_supply_sysfs.c |    4 +++-
>  include/linux/power_supply.h       |    3 ++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
> index 58cc490..6250686 100644
> --- a/drivers/power/power_supply_sysfs.c
> +++ b/drivers/power/power_supply_sysfs.c
> @@ -42,7 +42,7 @@ static ssize_t power_supply_show_property(struct device *dev,
>  					  struct device_attribute *attr,
>  					  char *buf) {
>  	static char *type_text[] = {
> -		"Battery", "UPS", "Mains", "USB",
> +		"Unknown", "Battery", "UPS", "Mains", "USB",
>  		"USB_DCP", "USB_CDP", "USB_ACA"
>  	};
>  	static char *status_text[] = {
> @@ -67,6 +67,8 @@ static ssize_t power_supply_show_property(struct device *dev,
>  	const ptrdiff_t off = attr - power_supply_attrs;
>  	union power_supply_propval value;
>  
> +	memset(&value, 0, sizeof(value));
> +
>  	if (off == POWER_SUPPLY_PROP_TYPE)
>  		value.intval = psy->type;
>  	else
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index 204c18d..9c83e04 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -123,7 +123,8 @@ enum power_supply_property {
>  };
>  
>  enum power_supply_type {
> -	POWER_SUPPLY_TYPE_BATTERY = 0,
> +	POWER_SUPPLY_TYPE_UNKNOWN = 0,
> +	POWER_SUPPLY_TYPE_BATTERY,
>  	POWER_SUPPLY_TYPE_UPS,
>  	POWER_SUPPLY_TYPE_MAINS,
>  	POWER_SUPPLY_TYPE_USB,		/* Standard Downstream Port */
> -- 
> 1.7.4.1
> 
> 
> Best Regards
> 
> Milo (Woogyom) Kim
> Texas Instruments Incorporated

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/