linux-kernel - Re: [PATCH] serial/documentation: fix name of DCD cpp symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120105003753.1e6d2ed2@bob.linux.org.uk>
Date:	Thu, 5 Jan 2012 00:37:53 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH] serial/documentation: fix name of DCD cpp symbol

On Wed, 04 Jan 2012 15:13:29 -0800
Randy Dunlap <rdunlap@...otime.net> wrote:

> On 12/02/2011 03:42 PM, Alan Cox wrote:
> > On Fri,  2 Dec 2011 21:20:11 +0100
> > Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
> > 
> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> >> ---
> >>  Documentation/serial/driver |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/Documentation/serial/driver
> >> b/Documentation/serial/driver index 77ba0af..0a25a91 100644
> >> --- a/Documentation/serial/driver
> >> +++ b/Documentation/serial/driver
> >> @@ -101,7 +101,7 @@ hardware.
> >>  	Returns the current state of modem control inputs.  The
> >> state of the outputs should not be returned, since the core keeps
> >>  	track of their state.  The state information should
> >> include:
> >> -		- TIOCM_DCD	state of DCD signal
> >> +		- TIOCM_CAR	state of DCD signal
> >>  		- TIOCM_CTS	state of CTS signal
> >>  		- TIOCM_DSR	state of DSR signal
> >>  		- TIOCM_RI	state of RI signal
> > 
> > Acked-by: Alan Cox <alan@...ux.intel.com>
> > 
> > but please fix the Subject line to be less confusing - it sounds
> > like it changes the define not the docs... 
> 
> 
> (sorry for the delayed reply)
> 
> I thought that DCD meant Data Carrier Detect.  Is that old?  Has it
> changed to just Carrier?

TIOCM_ are the kernel names. The documentation says we use TIOCM_DCD -
only we don't - the #define is TIOCM_CAR

So its a fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/