linux-kernel - Re: iwl3945 didn't survive after s2ram failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120105141913.GA3937@tiehlicka.suse.cz>
Date:	Thu, 5 Jan 2012 15:19:13 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	linux-wireless@...r.kernel.org,
	Stanislaw Gruszka <sgruszka@...hat.com>
Subject: Re: iwl3945 didn't survive after s2ram failure

On Thu 05-01-12 12:07:45, Stanislaw Gruszka wrote:
[...]
> Only interesting thing we do while resume in the driver is:
> pci_write_config_byte(pdev, PCI_CFG_RETRY_TIMEOUT, 0x00); 
> we do the same during erly stage of .probe function too.
> 
> In the RH bugzilla case, it was regression. There are no iwlegacy
> changes between mentioned kernel versions. There are some APCI and pci
> changes. Can you try if any of these kernel boot parameters helps:
> pcie_aspm=off
> pcie_aspm=force
> pci=nocsr
> pci=use_csr

OK, so I have tried to boot with pcie_aspm=off and the wireless
resurrect. The I found out that I booted into 3.2 rather than 3.2-rc6 so
I retested with the original kernel and guess what, yes it reported the
same problem as before (with or without parameter). 
So I have tried to retest with few kernels (3.2.0-rc5,
3.2.0-rc6-00005-ga36bfdd, 3.2.0-rc7-00083-g115e8e7 and 3.2.0) that I
still had on my machine and 3.2.0-rc6-00005-ga36bfdd seems to be the
only affected one.
There doesn't seem to be any obvious difference wrt. the driver in the
logs (attached).

Looking in the history it seems that 497f16f2 [pci: Fix hotplug of
Express Module with pci bridges] might be related. It fixes an issue
introduced by bbef98ab [PCI: defer enablement of SRIOV BARS] which is a
part of my 3.2.0-rc6-00005-ga36bfdd problematic version. But I do not
understand details of the patch so I cannot tell that for 100%.
Yinghai Lu, is it possible that I the problem I have seen is somehow
related? For reference the thread started at
https://lkml.org/lkml/2011/12/27/65

Thanks
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/