linux-kernel - Re: [PATCH 2/7] rtlwifi: Standardize RT_PRINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F05C7CB.3000607@lwfinger.net>
Date:	Thu, 05 Jan 2012 09:54:51 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
CC:	Joe Perches <joe@...ches.com>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] rtlwifi: Standardize RT_PRINT_DATA macro and uses

On 01/05/2012 05:43 AM, Stanislaw Gruszka wrote:
> Hi Joe
>
> On Wed, Jan 04, 2012 at 07:40:40PM -0800, Joe Perches wrote:
>>   	RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_DMESG,
>
> Since you are working on it, can you also get rid of this DBG_*
> parameter, if rtlwifi maintainers are ok with that? It is additional
> console loglvevel, standard kernel loglevel should be used.

I'm not OK with that. Those DBG_* parameters are used in conjunction with a 
load-time debug parameter to set the level of debugging. You could rename all of 
them, but that would be useless churning of the source with no real value.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/