linux-kernel - Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwcZjxZsVV_9rsKgApDfEMdCdHYvkDW5Wz7j-=gd_tFeQ@mail.gmail.com>
Date:	Thu, 5 Jan 2012 08:16:06 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Willy Tarreau <w@....eu>, linux-kernel@...r.kernel.org,
	security@...nel.org, pmatouse@...hat.com, agk@...hat.com,
	jbottomley@...allels.com, mchristi@...hat.com, msnitzer@...hat.com,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

On Thu, Jan 5, 2012 at 5:18 AM, Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> Hence, changing scsi_verify_blk_ioctl to return ENOIOCTLCMD is not
> really possible.

What?

"We have a bug in the block IO layer, so we cannot possible fix
another problem?"

Whjat the f*ck is the logic there?

Just fix the *obvious* breakage in BLKROSET. It's clearly what the
code *intends* to do, it just didn't check for ENOIOCTLCMD.

In fact, fixing that BLKROSET case would make it much more obvious
*why* it has those error tests at all. And we really should try to
just remove the crazy EINVAL case, because it really is wrong - and
then fix any broken drivers that exposes.

It's a DISEASE how you seem to think that "we have ugly mistakes in
the kernel, SO LET'S ADD ANOTHER ONE".

That's not how we do things. We *fix* things, instead of making things
even *worse*.

Stop this insanity from spreading, instead of making it spread more!

                           Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/