linux-kernel - Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwi2xWsmRb+kMsqJ5cq5c8WD=iPZS9WXU=9VRVaJCu2sQ@mail.gmail.com>
Date:	Thu, 5 Jan 2012 09:04:31 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Willy Tarreau <w@....eu>, linux-kernel@...r.kernel.org,
	security@...nel.org, pmatouse@...hat.com, agk@...hat.com,
	jbottomley@...allels.com, mchristi@...hat.com, msnitzer@...hat.com,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

On Thu, Jan 5, 2012 at 8:40 AM, Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> Aha, so this is clear and obvious.  And who knows that something else won't
> break?  Such as the 32-on-64 logic that already uses ENOIOCTLCMD for
> something else?

Exactly. Which is why we can try to do this in the merge window, and
fix up the fallout.

> Foolish me who found a bug, and an exploitable one for that matter, and even
> tried to fix it.  Looks like security by obscurity would have served users better.

Umm. I just sent out what I think is what we *should* be doing.

You are the one who seems to just want to add hack upon hack to
things. THAT is what I really hate. It's not only in bad taste, it
*will* come back and bite us some day.

If you think that "security" is about adding new special cases and
hacks, you're so out to lunch that it isn't even funny. It is
absolutely the *last* thing you want.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/