linux-kernel - Re: Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyDJ5PJ75R_bSaV5KCpLANmNwCjCA=mYj4g+H+35NQSNQ@mail.gmail.com>
Date:	Thu, 5 Jan 2012 09:47:26 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
Cc:	Paolo Bonzini <pbonzini@...hat.com>, linux-media@...r.kernel.org,
	Willy Tarreau <w@....eu>, linux-kernel@...r.kernel.org,
	security@...nel.org, pmatouse@...hat.com, agk@...hat.com,
	jbottomley@...allels.com, mchristi@...hat.com, msnitzer@...hat.com,
	Christoph Hellwig <hch@....de>
Subject: Re: Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI
 passthrough ioctls on partition devices)

On Thu, Jan 5, 2012 at 9:37 AM, Mauro Carvalho Chehab
<mchehab@...radead.org> wrote:
>
> For the media drivers, we've already fixed it, at the V4L side:
> -EINVAL doesn't mean that an ioctl is not supported anymore.
> I think that such fix went into Kernel 3.1.

Ok, I'm happy to hear that the thing should be fixed. My grepping
still found a fair amount of EINVAL returns both in code and in the
Documentation subdirectory for media ioctls, but it really was just
grepping with a few lines of context, so I didn't look closer at the
semantics. I was just looking for certain patterns (ie grepping for
"EINVAL" near ioctl or ENOIOCTLCMD etc) that I thought might indicate
problem spots, and the media subdirectory had a lot of them.

Can you test the patch with some media capture apps (preferably with
the obvious fix for the problem that Paulo already pointed out -
although that won't actually matter until some block driver starts
using ENOIOCTLCMD there, so even the unfixed patch should mostly work
for testing)?

                              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/