linux-kernel - Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874nwbc8wm.fsf@rustcorp.com.au>
Date:	Thu, 05 Jan 2012 10:33:53 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Tomi Valkeinen <tomi.valkeinen@...com>
Cc:	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pawel Moll <pawel.moll@....com>
Subject: Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)

On Wed, 04 Jan 2012 09:12:18 +0200, Tomi Valkeinen <tomi.valkeinen@...com> wrote:
Non-text part: multipart/signed
> Hi,
> 
> On Thu, 2011-12-15 at 13:48 +1030, Rusty Russell wrote:
> > module_param(bool) used to counter-intuitively take an int.  In
> > fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
> > trick.
> > 
> > It's time to remove the int/unsigned int option.  For this version
> > it'll simply give a warning, but it'll break next kernel version.
> > 
> > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> 
> The changes below break compilation for omapdss and omapfb: dss_debug
> and omapfb_debug are declared in dss.h and omapfb.h, and those
> declarations are not changed, resulting in conflicting types error.
> 
> Perhaps extra care should be taken in cases where the variable in
> question is not declared as static.

Yes, after the first few hours I got lazy.  Obviously, linux-next
doesn't build with CONFIG_OMAP2_DSS_DEBUG_SUPPORT (or may not build OSS2
at all), so it didn't catch them either.

I've fixed it (probably tomorrow's linux-next), but hope that the
introduction of a 'bool' in that header doesn't break anything else.

Please post fix if it does.  Though I think the new hotness is dev_debug
and dynamic debugging.

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/