linux-kernel - Re: [PATCH v2 2/4] toshiba_acpi: Support alternate hotkey interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jan 2012 18:25:22 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Seth Forshee <seth.forshee@...onical.com>
Cc:	Len Brown <lenb@...nel.org>, Azael Avalos <coproscefalo@...il.com>,
	Thomas Renninger <trenn@...e.de>,
	platform-driver-x86@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] toshiba_acpi: Support alternate hotkey
 interfaces

On Tue, Jan 03, 2012 at 01:02:36PM -0600, Seth Forshee wrote:
> There are two types of problems that prevent hotkeys from working
> on many of the machines supported by toshiba_acpi. The first of
> these is the lack of a functioning SCI for hotkey events. For these
> machines it is possible to filter the Fn keypresses from the
> keyboard and generate a notification by executing the ACPI NTFY
> method.
> 
> The second problem is a lack of support for HCI_SYSTEM_EVENT, which
> is used for reading the hotkey scancodes. On these machines the
> scancodes can be read by executing the ACPI NTFY method.
> 
> This patch fixes both problems by installing an i8042 filter when
> the NTFY method is present to generate notifications and by
> detecting which of INFO or HCI_SYSTEM_EVENT is supported for
> reading scancodes. If neither method of reading scancodes is
> supported, the hotkey input device is not registered.
> 
> Signed-off-by: Azael Avalos <coproscefalo@...il.com>
> Signed-off-by: Seth Forshee <seth.forshee@...onical.com>

It's still an awful way to implement things, but it doesn't seem like 
there's any alternative, so sure.

> +		error = i8042_install_filter(toshiba_acpi_i8042_filter);

If this is only needed for TOS1900 machines then I think I'd prefer to 
see it only done on them. Just add a flag to the data field of the IDs 
and check that.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/