linux-kernel - Re: [PATCH v2 4/4] toshiba_acpi: Add blacklist for models with hotkey problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jan 2012 14:24:29 -0600
From:	Seth Forshee <seth.forshee@...onical.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Len Brown <lenb@...nel.org>, Azael Avalos <coproscefalo@...il.com>,
	Thomas Renninger <trenn@...e.de>,
	platform-driver-x86@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] toshiba_acpi: Add blacklist for models with
 hotkey problems

On Thu, Jan 05, 2012 at 08:09:26PM +0000, Matthew Garrett wrote:
> On Thu, Jan 05, 2012 at 02:04:32PM -0600, Seth Forshee wrote:
> > On Thu, Jan 05, 2012 at 07:34:31PM +0000, Matthew Garrett wrote:
> > > In that case, can you check for the presence of the WMI interface and 
> > > then refuse to bind? That's seem far simpler than adding an unknown 
> > > number of systems to the blacklist.
> > 
> > Hmm, I suppose I could look for the specific WMI event guid, although
> > the relationship between the two seems tenuous at best. It would make
> > sense to me if we were refusing to bind because there was a better
> > interface available, but Toshiba is obviously treating hotkeys on the
> > WMI interface as legacy since it's disabled in the BIOS for Vista or
> > later. INFO seems to be the preferred interface.
> 
> ...but doesn't work?

Yes. But that's not because of the WMI interface. They both just belong
to the same BIOS implementation. There's no reason why a future machine
couldn't have this WMI interface along with a working INFO
implementation.

For now that's theoretical though, so I'll change it to use the guid
instead of the blacklist. If such a machine appears in the future we can
deal with it then.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/