linux-kernel - Re: [PATCH] Correctly deal with make that has an argument which contains an "s"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jan 2012 16:46:30 -0600
From:	Jason Wessel <jason.wessel@...driver.com>
To:	Michal Marek <mmarek@...e.cz>
CC:	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kbuild <linux-kbuild@...r.kernel.org>,
	Américo Wang 
	<xiyou.wangcong@...il.com>
Subject: Re: [PATCH] Correctly deal with make that has an argument which contains
 an "s"

On 04/27/2010 06:47 AM, Michal Marek wrote:
> On 26.4.2010 22:56, Jason Wessel wrote:
>> When using remake, which is based on gnumake, if you invoke
>> an example build as shown below, the build will become silent
>> due to the top level make file incorrectly guessing that
>> the end user wants a silent build because an argument that
>> contained an "s" was used.
>>
>> remake --no-extended-errors
> 
> BTW, make --warn-undefined-variables also triggers this (although no one
> will use this option on the kernel makefiles).
> 

Might as well add it to the commit header for clarity. 

>>  
>> -ifneq ($(findstring s,$(MAKEFLAGS)),)
>> +ifneq ($(filter s% -s% --silent --quiet,$(MAKEFLAGS)),)
> 
> I played a bit with GNU make 3.81. Checking for --silent and --quiet is
> not necessary, because make always stores the short option if available.
> Now I was wondering if the 's' option is always at the beginning,
> looking at make-3.81/main.c, it turns out that the order in which the
> options appear in $(MAKEFLAGS) is the reverse order of the switches
> array, where 's' is near the end of the array:
> 
[clip]
> 
> The only other single-letter options that come after 's' (before 's' in
> the $(MAKEFLAGS) variable) are 't', which doesn't work with the kernel,
> and 'w', which doesn't work either (the Makefile adds
> --no-print-directory). So we can indeed get away with s% and -s% (until
> the next make version changes the sort order, that is ;)).
> 

This might be nearly a whole year later, but the problem is still there so perhaps we can reach some closure and get it fixed since it is fairly minor in the first place.  :-)

Version 2 of the original patch is attached.

Thanks,
Jason.

View attachment "0001-Correctly-deal-with-make-that-has-an-argument-which-.patch" of type "text/x-diff" (1291 bytes)