| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1325847795-30486-2-git-send-email-clchiou@chromium.org> Date: Fri, 6 Jan 2012 19:03:15 +0800 From: Che-Liang Chiou <clchiou@...omium.org> To: dmitry.torokhov@...il.com Cc: linux-kernel@...r.kernel.org, Che-Liang Chiou <clchiou@...omium.org> Subject: [PATCH 2/2] Input: serio_raw - return error code instead of written on error Even if an error occurs and error code is set, serio_raw_write() returns the amount of bytes written anyway. If this behavior is actually desirable, serio_raw_write() should not even bother to set the error code because it is not intended to be returned to the caller. Signed-off-by: Che-Liang Chiou <clchiou@...omium.org> --- drivers/input/serio/serio_raw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c index a935c38..32416f7 100644 --- a/drivers/input/serio/serio_raw.c +++ b/drivers/input/serio/serio_raw.c @@ -224,7 +224,7 @@ static ssize_t serio_raw_write(struct file *file, const char __user *buffer, out: mutex_unlock(&serio_raw_mutex); - return written; + return retval ?: written; } static unsigned int serio_raw_poll(struct file *file, poll_table *wait) -- 1.7.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists