linux-kernel - Re: [PATCH] power_supply: wm97xx_battery: Use DEFINE_MUTEX() for work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120106010909.GB17587@oksana.dev.rtsoft.ru>
Date:	Fri, 6 Jan 2012 05:09:09 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>
Subject: Re: [PATCH] power_supply: wm97xx_battery: Use DEFINE_MUTEX() for
 work_lock

On Mon, Nov 28, 2011 at 10:37:35PM +0800, Axel Lin wrote:
> work_lock can be initialized automatically with
> DEFINE_MUTEX() rather than explicitly calling mutex_init().
> 
> This patch also removes an unused bat_lock mutex.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Applied, thanks!

> ---
>  drivers/power/wm97xx_battery.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/wm97xx_battery.c b/drivers/power/wm97xx_battery.c
> index cf8681c..eaa454b 100644
> --- a/drivers/power/wm97xx_battery.c
> +++ b/drivers/power/wm97xx_battery.c
> @@ -25,9 +25,8 @@
>  #include <linux/irq.h>
>  #include <linux/slab.h>
>  
> -static DEFINE_MUTEX(bat_lock);
>  static struct work_struct bat_work;
> -static struct mutex work_lock;
> +static DEFINE_MUTEX(work_lock);
>  static int bat_status = POWER_SUPPLY_STATUS_UNKNOWN;
>  static enum power_supply_property *prop;
>  
> @@ -181,8 +180,6 @@ static int __devinit wm97xx_bat_probe(struct platform_device *dev)
>  	if (dev->id != -1)
>  		return -EINVAL;
>  
> -	mutex_init(&work_lock);
> -
>  	if (!pdata) {
>  		dev_err(&dev->dev, "No platform_data supplied\n");
>  		return -EINVAL;
> -- 
> 1.7.5.4

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/