linux-kernel - Re: [PATCH 5/6] usb: add support for STA2X11 host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1201061132170.1326-100000@iolanthe.rowland.org>
Date:	Fri, 6 Jan 2012 11:35:12 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Alessandro Rubini <rubini@...dd.com>
cc:	linux-kernel@...r.kernel.org, <giancarlo.asnaghi@...com>,
	<alan@...ux.intel.com>, <tglx@...utronix.de>, <mingo@...hat.com>,
	<hpa@...or.com>, <x86@...nel.org>, <gregkh@...e.de>,
	<linux-usb@...r.kernel.org>
Subject: Re: [PATCH 5/6] usb: add support for STA2X11 host driver

On Fri, 6 Jan 2012, Alessandro Rubini wrote:

> Signed-off-by: Alessandro Rubini <rubini@...dd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@...com>
> Cc: Alan Cox <alan@...ux.intel.com>
> ---
>  drivers/usb/host/ehci-pci.c |    6 ++++++
>  drivers/usb/host/ohci-pci.c |    4 ++++
>  2 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> index f4b627d..01bb7241d 100644
> --- a/drivers/usb/host/ehci-pci.c
> +++ b/drivers/usb/host/ehci-pci.c
> @@ -276,6 +276,9 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
>  
>  	/* Serial Bus Release Number is at PCI 0x60 offset */
>  	pci_read_config_byte(pdev, 0x60, &ehci->sbrn);
> +	if (pdev->vendor == PCI_VENDOR_ID_STMICRO
> +	    && pdev->device == PCI_DEVICE_ID_STMICRO_USB_HOST)
> +		ehci->sbrn = 0x20; /* ConneXT has no sbrn register */
>  
>  	/* Keep this around for a while just in case some EHCI
>  	 * implementation uses legacy PCI PM support.  This test
> @@ -526,6 +529,9 @@ static const struct pci_device_id pci_ids [] = { {
>  	/* handle any USB 2.0 EHCI controller */
>  	PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_EHCI, ~0),
>  	.driver_data =	(unsigned long) &ehci_pci_hc_driver,
> +	}, {
> +	PCI_VDEVICE(STMICRO, PCI_DEVICE_ID_STMICRO_USB_HOST),
> +	.driver_data = (unsigned long) &ehci_pci_hc_driver,
>  	},
>  	{ /* end: all zeroes */ }
>  };
> diff --git a/drivers/usb/host/ohci-pci.c b/drivers/usb/host/ohci-pci.c
> index 6109810..1843bb6 100644
> --- a/drivers/usb/host/ohci-pci.c
> +++ b/drivers/usb/host/ohci-pci.c
> @@ -397,6 +397,10 @@ static const struct pci_device_id pci_ids [] = { {
>  	/* handle any USB OHCI controller */
>  	PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_OHCI, ~0),
>  	.driver_data =	(unsigned long) &ohci_pci_hc_driver,
> +	}, {
> +	/* The device in the ConneXT I/O hub has no class reg */
> +	PCI_VDEVICE(STMICRO, PCI_DEVICE_ID_STMICRO_USB_OHCI),
> +	.driver_data =	(unsigned long) &ohci_pci_hc_driver,
>  	}, { /* end: all zeroes */ }
>  };
>  MODULE_DEVICE_TABLE (pci, pci_ids);

Acked-by: Alan Stern <stern@...land.harvard.edu>

Why doesn't the ConneXT implement the required PCI registers?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/