linux-kernel - [PATCH] kprobe: fix a memory leak in function pre_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F07261A.6080403@gmail.com>
Date:	Sat, 07 Jan 2012 00:49:30 +0800
From:	Jiang Liu <liuj97@...il.com>
To:	Hien Nguyen <hien@...ibm.com>, Jim Keniston <jkenisto@...ibm.com>,
	Prasanna S Panchamukhi <prasanna@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] kprobe: fix a memory leak in function pre_handler_kretprobe()

From: Jiang Liu<liuj97@...il.com>

In function pre_handler_kretprobe(), the allocated kretprobe_instance object will
be leaked if the entry_handler callback returns non-zero. This may cause all the
preallocated kretprobe_instance objects exhausted. This issue could be reproduced
by changing samples/kprobes/kretprobe_example.c to probe "mutex_unlock". And the
fix is straight forward, just put the allocated kretprobe_instance object back
onto the free_instances list.

Signed-off-by: Jiang Liu<liuj97@...il.com>
Cc: Hien Nguyen<hien@...ibm.com>
Cc: Jim Keniston<jkenisto@...ibm.com>
Cc: Prasanna S Panchamukhi<prasanna@...ibm.com>
---
  kprobes.c |    6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1660,8 +1660,12 @@
                 ri->rp = rp;
                 ri->task = current;

-               if (rp->entry_handler&&  rp->entry_handler(ri, regs))
+               if (rp->entry_handler&&  rp->entry_handler(ri, regs)) {
+                       spin_lock_irqsave(&rp->lock, flags);
+                       hlist_add_head(&ri->hlist,&rp->free_instances);
+                       spin_unlock_irqrestore(&rp->lock, flags);
                         return 0;
+               }

                 arch_prepare_kretprobe(ri, regs);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/