linux-kernel - Re: [PATCH] irqdomain: Initialize number of IRQs for simple domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F072843.6050306@ti.com>
Date:	Fri, 6 Jan 2012 17:58:43 +0100
From:	"Cousson, Benoit" <b-cousson@...com>
To:	Thierry Reding <thierry.reding@...onic-design.de>
CC:	<devicetree-discuss@...ts.ozlabs.org>,
	Tony Lindgren <tony@...mide.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Daniel Walker <dwalker@...o99.com>,
	Russell King <linux@....linux.org.uk>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	David Brown <davidb@...eaurora.org>,
	"open list:ARM/QUALCOMM MSM..." <linux-arm-msm@...r.kernel.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Barry Song <baohua.song@....com>,
	Thomas Gleixner <tglx@...utronix.de>, open list:
	OMAP SUPPORT <linux-omap@...r.kernel.org>,
	Andrew Victor <linux@...im.org.za>,
	"open list:ARM/ATMEL AT91RM9..." 
	<linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Richard Zhao <richard.zhao@...escale.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	David Woodhouse <dwmw2@...radead.org>, ;
Subject: Re: [PATCH] irqdomain: Initialize number of IRQs for simple domains

Hi Thierry,

On 1/6/2012 3:28 PM, Thierry Reding wrote:
> The irq_domain_add() function needs the number of interrupts in the
> domain to properly initialize them. In addition the allocated domain
> is now returned by the irq_domain_{add,generate}_simple() helpers.

[...]

> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index d587560..bf67781 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -66,8 +66,11 @@ static struct of_device_id intc_match[] __initdata = {
>   static void __init omap_generic_init(void)
>   {
>   	struct device_node *node = of_find_matching_node(NULL, intc_match);
> -	if (node)
> -		irq_domain_add_simple(node, 0);
> +	if (node) {
> +		struct irq_domain *domain;
> +		domain = irq_domain_add_simple(node, 0, INTCPS_NR_IRQS);

The number of interrupts will depend on the OMAP generation. That one is 
just valid for the 3430 INTC controller.
Since the previous code was using zero, I guess that using 0 there 
should be fine.

Moreover, that piece of code should not exist anymore on 3.3 if the 
series I sent last month to leverage Rob's DT interrupt init is merged [1].

I've just ping Rob and Grant on that series to get a status.

Regards,
Benoit


[1] http://www.spinics.net/lists/linux-omap/msg62124.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/