linux-kernel - Re: [PATCH -v2] pciehp: Checking pci conf reading to new added device instead of sleep 1s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jan 2012 12:52:33 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Matthew Wilcox <matthew@....cx>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -v2] pciehp: Checking pci conf reading to new added
 device instead of sleep 1s

On Fri, 16 Dec 2011 16:52:45 -0800
Yinghai Lu <yinghai@...nel.org> wrote:

> During reviewing
> |	PCI: pciehp: wait 1000 ms before Link Training check
> Linus said:
> >...
> > That's a *long* time, and it's irritating to the user. It makes the
> > user think "the machine is slow".
> >...
> > And quite frankly, an unconditional one-second delay here seems bad.
> >Two seconds was unacceptable, one second is just bad.
> 
> Try to access the pci conf of pci device that is supposed to show up in 1s,
> if could read back valid vender/device id, could bail out early.
> 
> Related discussion could be found:
> 	https://lkml.org/lkml/2011/12/6/339
> 
> -v2: seperate code to pci_bus_read_dev_vendor_id() from pci_scan_device()
>     and reuse it from pciehp code. Suggested by Matthew Wilcox.

Kenji-san, you ok with this one?  Any chance you could test?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)