linux-kernel - Re: [PATCH] net: fix sock_clone reference mismatch with tcp memcontrol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20120106211423.967A716F64A@chavey.mtv.corp.google.com>
Date:	Fri,  6 Jan 2012 13:14:23 -0800 (PST)
From:	chavey@...gle.com (Laurent Chavey)
To:	Glauber Costa <glommer@...allels.com>
CC:	davem@...emloft.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, cgroups@...r.kernel.org,
	Greg Thelen <gthelen@...gle.com>,
	Hiroyouki Kamezawa <kamezawa.hiroyu@...fujitsu.com>,
	Laurent Chavey <chavey@...gle.com>
Subject: Re: [PATCH] net: fix sock_clone reference mismatch with tcp memcontrol

> Sockets can also be created through sock_clone. Because it copies
> all data in the sock structure, it also copies the memcg-related pointer,
> and all should be fine. However, since we now use reference counts in
> socket creation, we are left with some sockets that have no reference
> counts. It matters when we destroy them, since it leads to a mismatch.
>
> Signed-off-by: Glauber Costa <glommer@...allels.com>
> CC: David S. Miller <davem@...emloft.net>
> CC: Greg Thelen <gthelen@...gle.com>
> CC: Hiroyouki Kamezawa <kamezawa.hiroyu@...fujitsu.com>
> CC: Laurent Chavey <chavey@...gle.com>
>
> ---

Tested-by: Laurent Chavey <chavey@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/