linux-kernel - Re: [PATCH -next] fs: fix fs/fs-writeback.c build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFx7vzez6C5M6EmZPDmkHig-mY=p64vZWWmWWe-nmxH4=w@mail.gmail.com>
Date:	Fri, 6 Jan 2012 15:01:09 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Randy Dunlap <rdunlap@...otime.net>,
	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] fs: fix fs/fs-writeback.c build error

On Thu, Jan 5, 2012 at 4:18 PM, Randy Dunlap <rdunlap@...otime.net> wrote:
>
> In linux-next, fs/fs-writeback.c no longer #includes <linux/buffer_head.h>,
> which #included <linux/pagemap.h>, so add that latter header file to
> <linux/writeback.h> to fix the build error:
>
> fs/fs-writeback.c:510:11: error: 'PAGE_CACHE_SHIFT' undeclared (first use in this function)

I would actually suggest:

 - move the whole MIN_WRITEBACK_PAGES #define from the header file to
fs/writeback.c (why expose such a random #define to outside users that
have nothing to do with it?)

 - make sure that fs/fs-writeback.c has that pagemap.h #include.

There's no reason why <linux/writeback.h> should include filemap.h per
se, and there is no reason why it should expose some internal chunking
#define to anybody else.

Wu?

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/