linux-kernel - Re: [PATCH] i2c: convert drivers/i2c/* to use module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120107160018.43c9d7fe@endymion.delvare>
Date:	Sat, 7 Jan 2012 16:00:18 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ben Dooks <ben-linux@...ff.org>,
	Jochen Friedrich <jochen@...am.de>,
	Peter Korsgaard <jacmet@...site.dk>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Guan Xuetao <gxt@...c.pku.edu.cn>,
	Manuel Lauss <manuel.lauss@...glemail.com>,
	Barry Song <21cnbao@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Yong Zhang <yong.zhang0@...il.com>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Grant Likely <grant.likely@...retlab.ca>,
	Samuel Ortiz <sameo@...ux.intel.com>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: convert drivers/i2c/* to use 
 module_platform_driver()

Axel,

On Sun, 27 Nov 2011 20:22:12 +0100, Jean Delvare wrote:
> On Sun, 27 Nov 2011 14:12:12 +0800, Axel Lin wrote:
> > diff --git a/drivers/i2c/muxes/gpio-i2cmux.c b/drivers/i2c/muxes/gpio-i2cmux.c
> > index 7b6ce62..e5fa695 100644
> > --- a/drivers/i2c/muxes/gpio-i2cmux.c
> > +++ b/drivers/i2c/muxes/gpio-i2cmux.c
> > @@ -165,18 +165,7 @@ static struct platform_driver gpiomux_driver = {
> >  	},
> >  };
> >  
> > -static int __init gpiomux_init(void)
> > -{
> > -	return platform_driver_register(&gpiomux_driver);
> > -}
> > -
> > -static void __exit gpiomux_exit(void)
> > -{
> > -	platform_driver_unregister(&gpiomux_driver);
> > -}
> > -
> > -module_init(gpiomux_init);
> > -module_exit(gpiomux_exit);
> > +module_platform_driver(gpiomux_driver);
> 
> This one would be better as a separate patch, as it touches a different
> subdirectory, which I am responsible for.

You resent a v2 of the patch without muxes/gpio-i2cmux.c, which is
good, but I never received the suggested separate patch for
muxes/gpio-i2cmux.c. Did I miss it somehow? Please send it quickly if
you want it to make it into kernel 3.3.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/