linux-kernel - Re: [PATCH v2 1/4] ACPI: EC: Add ec_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPbh3rv86E9zqUbF4vrA2G=FaXyNHqD7+NZXRkzrzYAsHL8a_Q@mail.gmail.com>
Date:	Sat, 7 Jan 2012 15:55:35 -0500
From:	Konrad Rzeszutek Wilk <konrad@...nok.org>
To:	Konrad Rzeszutek Wilk <konrad@...nok.org>,
	Thomas Renninger <trenn@...e.de>,
	Matthew Garrett <mjg@...hat.com>, linux-acpi@...r.kernel.org,
	Azael Avalos <coproscefalo@...il.com>,
	platform-driver-x86@...r.kernel.org, Len Brown <lenb@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] ACPI: EC: Add ec_get_handle()

On Thu, Jan 5, 2012 at 2:34 PM, Seth Forshee <seth.forshee@...onical.com> wrote:
> On Thu, Jan 05, 2012 at 01:27:08PM -0500, Konrad Rzeszutek Wilk wrote:
>> 8
>> On Jan 3, 2012 2:05 PM, "Seth Forshee" <seth.forshee@...onical.com> wrote:
>> >
>> > toshiba_acpi needs to execute an AML method within the EC namespace
>> > to make hotkeys work on some platforms. Provide an interface to
>> > allow it to easily get a handle to the EC namespace for this purpose.
>> >
>> > Signed-off-by: Seth Forshee <seth.forshee@...onical.com>
>> > ---
>> >  drivers/acpi/ec.c    |   10 ++++++++++
>> >  include/linux/acpi.h |    1 +
>> >  2 files changed, 11 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
>> > index b19a18d..e37615f 100644
>> > --- a/drivers/acpi/ec.c
>> > +++ b/drivers/acpi/ec.c
>> > @@ -445,6 +445,16 @@ int ec_transaction(u8 command,
>> >
>> >  EXPORT_SYMBOL(ec_transaction);
>> >
>> > +/* Get the handle to the EC device */
>> > +acpi_handle ec_get_handle(void)
>> > +{
>> > +       if (!first_ec)
>> > +               return NULL;
>> > +       return first_ec->handle;
>> > +}
>> > +
>> > +EXPORT_SYMBOL(ec_get_handle);
>>
>> shouldn't this be _GPL?
>
> I don't know. All the other ec_* interfaces are EXPORT_SYMBOL, so I did
> likewise. I'm happy to change it if _GPL is what ought to be used here.

My understanding (and this is from reading Greg KH's patches) is that
any new interface should use _GPL variant unless there is an absolute
need for it. Say, a binary driver that uses this function and there is
no other way around it.

>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/