linux-kernel - Re: [PATCH v4] regulator: Add S5M8767A regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120109084150.GK22134@opensource.wolfsonmicro.com>
Date:	Mon, 9 Jan 2012 00:41:51 -0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Sangbeom Kim <sbkim73@...sung.com>
Cc:	lrg@...com, sameo@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] regulator: Add S5M8767A regulator driver

On Mon, Jan 09, 2012 at 05:35:47PM +0900, Sangbeom Kim wrote:

> After delete above functions, Is it right to code like below?

> +static struct regulator_ops s5m8767_buck_ops = {
> +	.enable	 = s5m8767_reg_enable,
> +	.disable	 = s5m8767_reg_disable,
> +	.set_suspend_enable	= s5m8767_reg_enable,
> +	.set_suspend_disable	= s5m8767_reg_disable,

No.  If your hardware doesn't have this feature your driver shouldn't
pretend it does, and if such a mapping were a good way of implementing
this we'd be better doing it in the core.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/