lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1326121948.6755.102.camel@sauron.fi.intel.com>
Date:	Mon, 09 Jan 2012 17:12:28 +0200
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Richard Weinberger <rw@...utronix.de>
Cc:	linux-mtd@...ts.infradead.org, dwmw2@...radead.org,
	linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH] [RFC] ubi: Make vid_hdr non-static

On Thu, 2011-12-22 at 18:06 +0200, Artem Bityutskiy wrote:
> On Thu, 2011-12-22 at 16:12 +0100, Richard Weinberger wrote:
> > There is no reason to have vid_hdr static.
> > 
> > Signed-off-by: Richard Weinberger <rw@...utronix.de>
> > ---
> >  drivers/mtd/ubi/vtbl.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
> > index 9ad18da..890754c 100644
> > --- a/drivers/mtd/ubi/vtbl.c
> > +++ b/drivers/mtd/ubi/vtbl.c
> > @@ -306,7 +306,7 @@ static int create_vtbl(struct ubi_device *ubi, struct ubi_scan_info *si,
> >  		       int copy, void *vtbl)
> >  {
> >  	int err, tries = 0;
> > -	static struct ubi_vid_hdr *vid_hdr;
> > +	struct ubi_vid_hdr *vid_hdr;
> >  	struct ubi_scan_leb *new_seb;
> 
> Hmm, this shouldn't be [RFC] - this a bugfix, I'll merge it, thanks!

Pushed to ubifs-2.6 git tree with "Cc: stable@...nel.org", thanks!

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ