lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Jan 2012 10:11:24 -0500 From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> To: Ian Campbell <Ian.Campbell@...rix.com> Cc: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>, "xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Jan Beulich <JBeulich@...e.com> Subject: Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning message to include domain id. On Mon, Jan 09, 2012 at 09:50:57AM +0000, Ian Campbell wrote: > On Fri, 2012-01-06 at 22:19 +0000, Konrad Rzeszutek Wilk wrote: > > > > I suppose you might want "Overriding ownership to dom%d". > > > > > > OK. To the point and potentially can fit in 80 lines :-). > > > > how about this? > > > > > From a3d4a80cdfd4274016522572148a89260b3f3de6 Mon Sep 17 00:00:00 2001 > > From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> > > Date: Wed, 4 Jan 2012 14:16:45 -0500 > > Subject: [PATCH] xen/pciback: Expand the warning message to include domain > > id. > > > > When a PCI device is transferred to another domain and it is still > > in usage (from the internal perspective), mention which other > > domain is using it to aid in debugging. > > > > [v2: Truncate the verbose message per Jan Beulich suggestion] > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> > > --- > > drivers/xen/xen-pciback/xenbus.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c > > index 474d52e..2405a24 100644 > > --- a/drivers/xen/xen-pciback/xenbus.c > > +++ b/drivers/xen/xen-pciback/xenbus.c > > @@ -243,8 +243,8 @@ static int xen_pcibk_export_device(struct xen_pcibk_device *pdev, > > dev_dbg(&dev->dev, "registering for %d\n", pdev->xdev->otherend_id); > > if (xen_register_device_domain_owner(dev, > > pdev->xdev->otherend_id) != 0) { > > - dev_err(&dev->dev, "device has been assigned to another " \ > > - "domain! Over-writting the ownership, but beware.\n"); > > + dev_err(&dev->dev, "Overriding ownership to dom%d.\n", > > + xen_find_device_domain_owner(dev)); > > That sounds like you are going to be assigning the ownership to that > dom, but xen_find_device_domain_owner so aren't you actually steeling > ownership from that domain? Duh! I will do s/to/from/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists