linux-kernel - Re: drivers/regulator/core.c: Fixes mapping inside regulator_mode_to_status() and makes it returning -EINVAL on invalid input.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Jan 2012 08:14:57 -0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Krystian Garbaciak <dd.diasemi@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: drivers/regulator/core.c: Fixes mapping inside
 regulator_mode_to_status() and makes it returning -EINVAL on invalid input.

On Mon, Jan 09, 2012 at 12:12:20PM +0000, Krystian Garbaciak wrote:
> Minor fix that makes the function working correctly with
> REGULATOR_MODE_STANDBY as parameter.
> Also, on invalid input (bad mode), it is better to return -EINVAL,
> instead of meaningless 0 value (which actually is interpreted as
> REGULATOR_STATUS_OFF).
> 
> --- 

As I previously said you need to follow the patch submission process in
SubmittingPatches.  Here you need to:

 - Sign off your patch.  Without this your patch cannot be applied.
 - Send the patches to the maintainers (not just one of them) and the
   list.

You should also make an effort to use subject lines for your patch that
match up with what the rest of the subsystem is doing.

>  	default:
> -		return 0;
> +		return -EINVAL;

This behaviour is deliberate.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/