linux-kernel - Re: [PATCH] drm/i915: set AUD_CONFIG N_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86y5tgx02g.fsf@sumi.keithp.com>
Date:	Mon, 09 Jan 2012 09:22:47 -0800
From:	Keith Packard <keithp@...thp.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Takashi Iwai <tiwai@...e.de>,
	Michal Marek <mmarek@...e.com>,
	"intel-gfx\@lists.freedesktop..." <intel-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

On Mon, 9 Jan 2012 21:17:17 +0800, Wu Fengguang <fengguang.wu@...el.com> wrote:

> +#define IBX_AUD_CONFIG_A		0xe2000
> +#define CPT_AUD_CONFIG_A		0xe5000

These register addresses match the docs.

> +		I915_WRITE(aud_config, 1 << 29); /* N value index, 0x1 = DP */

Please don't use constants here, instead add #defines for all of the
bits in this new register, in case someone else needs to use the
register later.

Do we also need to program the pixel clock values in this register?

-- 
keith.packard@...el.com

Content of type "application/pgp-signature" skipped