[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120109201110.GA8377@kroah.com>
Date: Mon, 9 Jan 2012 12:11:10 -0800
From: Greg KH <greg@...ah.com>
To: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc: Russell King - ARM Linux <linux@....linux.org.uk>,
Frank Mandarino <fmandarino@...relia.com>,
Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org
Subject: Re: Public ridicule due to sound/soc/soc-core.c abuse of the driver
model
On Mon, Jan 09, 2012 at 07:52:13PM +0000, Mark Brown wrote:
> On Mon, Jan 09, 2012 at 09:51:25AM +0000, Russell King - ARM Linux wrote:
>
> > Anything which helps reduce the abuses of the driver model is a plus -
> > it helps remove the possibility of kernel oopses.
>
> Trying to make any sort of modification to code this fragile is risky,
> especially during what's supposed to be a stabalization phase (which is
> what Greg is requesting). It just seems completely irresponsible for
> something that isn't actually a practical problem.
I find it hard to believe that ignoring the driver model is not a
"practical" problem :)
For details as to why this is a problem, please see the kobject.txt
file.
Please fix this up, as you have seen, people end up cutting-and-pasting
bad code.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists