linux-kernel - Re: linux-next: Tree for Jan 9 (arch/x86/pci/amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo4+remnOA6gJXOz_54CsbbcOq_Yj=ua9gV_bq5dZ64ABA@mail.gmail.com>
Date:	Mon, 9 Jan 2012 15:40:39 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Randy Dunlap <rdunlap@...otime.net>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	x86 maintainers <x86@...nel.org>, linux-pci@...r.kernel.org,
	Yinghai Lu <yinghai@...nel.org>
Subject: Re: linux-next: Tree for Jan 9 (arch/x86/pci/amd_bus.c)

On Mon, Jan 9, 2012 at 2:05 PM, Randy Dunlap <rdunlap@...otime.net> wrote:
> on several i386 builds:
>
> amd_bus.c:(.init.text+0x134b): undefined reference to `amd_get_mmconfig_range'

This is my fault.  I moved some code from amd_bus.c to amd_nb.c, and builds with

        CONFIG_PCI=y
        # CONFIG_AMD_NB not set

now fail.  The attached patch should fix it.  I'll repost the series
("x86/PCI: amd: factor out MMCONFIG discovery") with the fix.

Yinghai, it looks to me like there's no reason to build amd_bus.o
unless we have CONFIG_AMD_NB=y, but speak up if I'm wrong :)

Bjorn

Download attachment "patch.amd-build-fix" of type "application/octet-stream" (874 bytes)