linux-kernel - Re: [RFC PATCH v3 3/5] pinctrl: imx: add pinctrl imx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Jan 2012 14:32:12 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Richard Zhao <richard.zhao@...escale.com>
Cc:	Richard Zhao <richard.zhao@...aro.org>,
	linus.walleij@...ricsson.com, s.hauer@...gutronix.de,
	w.sang@...gutronix.de, rob.herring@...xeda.com,
	linux-kernel@...r.kernel.org, grant.likely@...retlab.ca,
	shawn.guo@...escale.com, kernel@...gutronix.de, cjb@...top.org,
	Dong Aisheng <b29396@...escale.com>,
	devicetree-discuss@...ts.ozlabs.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH v3 3/5] pinctrl: imx: add pinctrl imx driver

On Mon, Jan 09, 2012 at 10:17:03AM +0800, Richard Zhao wrote:
> On Mon, Jan 09, 2012 at 10:08:51AM +0800, Shawn Guo wrote:
> > On Sun, Jan 08, 2012 at 09:05:44PM +0800, Richard Zhao wrote:
> > > > +enum imx_imx53_pinctrl_pads {
> > > > +	MX53_GPIO_19 = 0,
> > > > +	MX53_KEY_COL0 = 1,
> > > > +	MX53_KEY_ROW0 = 2,
> > > > +	MX53_KEY_COL1 = 3,
> > > > +	MX53_KEY_ROW1 = 4,
> > > > +	MX53_KEY_COL2 = 5,
> > > > +	MX53_KEY_ROW2 = 6,
> > > ...
> > > Why not describe it in dts and make this file generic for imx?
> > > One node for one pad,
> > 
> > Doing this will bloat the device tree dramatically.  Actually I had
> > a patch doing so before the pinctrl subsystem was born, but it
> > concerned Grant a lot for that reason and thus died.
> are you against describing pad in dts or one node per pad?
> one node per pad is just a tip to extend pad property, to support
> other features (pinconf in your word).

I definitely want to describe pinconf in device tree, though what's
the best interface for pinctrl client driver to talk to pinconf is
still vague to me.

> > 
> > > it'll be easy to extend pad properties. You know
> > > the pad may set pull up/down, open drain, drive strenth, daisy chain etc.
> > > The features have to be supported, to make your model usefull.
> > > 
> > As Aisheng mentioned, the pinconf support will be added later.
> I expect pinconf come together, and get a ready-to-use patch series.
> 
As I was educated by Linus.W, we can not drink ocean and we need to
split big chunk of work into pieces and achieve it step by step.

-- 
Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/