linux-kernel - Re: [PATCH v6 7/8] mm: only IPI CPUs to drain local pages if they exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.v7vcjum63l0zgt@mpn-glaptop>
Date:	Tue, 10 Jan 2012 13:48:56 +0100
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Gilad Ben-Yossef" <gilad@...yossef.com>
Cc:	"Christoph Lameter" <cl@...ux.com>, linux-kernel@...r.kernel.org,
	"Chris Metcalf" <cmetcalf@...era.com>,
	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>,
	"Frederic Weisbecker" <fweisbec@...il.com>,
	"Russell King" <linux@....linux.org.uk>, linux-mm@...ck.org,
	"Pekka Enberg" <penberg@...nel.org>,
	"Matt Mackall" <mpm@...enic.com>,
	"Sasha Levin" <levinsasha928@...il.com>,
	"Rik van Riel" <riel@...hat.com>,
	"Andi Kleen" <andi@...stfloor.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Alexander Viro" <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, "Avi Kivity" <avi@...hat.com>
Subject: Re: [PATCH v6 7/8] mm: only IPI CPUs to drain local pages if they
 exist

> 2012/1/9 Michal Nazarewicz <mina86@...a86.com>:
>> This is initialised in setup_per_cpu_pageset() so it needs to be file
>> scoped.

On Tue, 10 Jan 2012 13:43:21 +0100, Gilad Ben-Yossef <gilad@...yossef.com> wrote:
> Yes. The cpumask_var_t abstraction is convenient and all but it does
> make the allocation very non obvious when it does not happen in
> proximity to the variable use - it doesn't *look* like a pointer.

You can say that about any file scoped variable that needs non-const
initialisation, not only pointers.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/