linux-kernel - Re: [27/27] clockevents: Set noop handler in clockevents_exchange

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1201101522590.3020@ionos>
Date:	Tue, 10 Jan 2012 15:23:35 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Jonathan Nieder <jrnieder@...il.com>, Greg KH <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Phil Miller <mille121@...inois.edu>
Subject: Re: [27/27] clockevents: Set noop handler in
 clockevents_exchange_device()

On Thu, 29 Dec 2011, Linus Torvalds wrote:

> On Thu, Dec 29, 2011 at 4:09 AM, Jonathan Nieder <jrnieder@...il.com> wrote:
> >
> > This is basically the reverse of 7c1e768974 (clockevents: prevent
> > clockevent event_handler ending up handler_noop, 2008-09-03).  The
> > rationale for the latter still applies.
> 
> Hmm. You seem to be right. Instead of applying this to stable, it
> looks like we should revert it from mainline.
> 
> >                  People have been reporting
> > the analagous patch to this one causing hangs on resume in 3.1.y and
> > 3.2 release candidates:
> >
> >  - http://thread.gmane.org/gmane.linux.kernel/1233033
> >  - http://thread.gmane.org/gmane.linux.kernel/1233389
> >  - http://thread.gmane.org/gmane.linux.kernel/1233159
> >  - http://thread.gmane.org/gmane.linux.kernel/1227868/focus=1230877
> >
> > So please consider reverting it for now.
> 
> Thomas? It does seem to be broken and there do seem to be regression
> reports about it.
> 
> Should I revert it, or do you have alternative fixes?

Hmm. I have no idea what broke. Will have a look.

Thanks,

	tglx