linux-kernel - [PATCH] gpio: gpio-langwell: fix IRQ wake functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 11 Jan 2012 11:08:08 +0200
From:	Mathias Nyman <mathias.nyman@...ux.intel.com>
To:	grant.likely@...retlab.ca
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
Subject: [PATCH] gpio: gpio-langwell: fix IRQ wake functionality

Some chips are able to use gpio as a wake up source - e.g., you may want your
gpio button to wake up your device.

Currently 'irq_set_irq_wake()' is broken for gpio-langwell because the driver
does not provide the '->irq_set_wake()' method, which makes 'set_irq_wake_real()'
return -ENXIO, so that the 'IRQD_WAKEUP_STATE' bit is not changed. This also
causes the "Unbalanced IRQ X wake disable" warnings at some point.

This patch fixes the issue with the 'IRQCHIP_SKIP_SET_WAKE' flag. This flag
basically tells the the IRQ core subsystem that we support IRQ wakes but do
not need any driver-specific code.

Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
---
 drivers/gpio/gpio-langwell.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c
index 00692e8..4bb748e 100644
--- a/drivers/gpio/gpio-langwell.c
+++ b/drivers/gpio/gpio-langwell.c
@@ -227,6 +227,7 @@ static struct irq_chip lnw_irqchip = {
 	.irq_mask	= lnw_irq_mask,
 	.irq_unmask	= lnw_irq_unmask,
 	.irq_set_type	= lnw_irq_type,
+	.flags		= IRQCHIP_SKIP_SET_WAKE,
 };

 static DEFINE_PCI_DEVICE_TABLE(lnw_gpio_ids) = {   /* pin number */
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/