linux-kernel - Re: [PATCH] power_supply: Fix modalias for charger-manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jan 2012 11:23:17 +0000 (GMT)
From:	함명주 <myungjoo.ham@...sung.com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	박경민 <kyungmin.park@...sung.com>,
	김동근 <dg77.kim@...sung.com>
Subject: Re: [PATCH] power_supply: Fix modalias for charger-manager

Written by Axel Lin<axel.lin@...il.com>
> Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform
> modalias is prefixed with "platform:".
> Current code has the id_table, thus add MODULE_DEVICE_TABLE will
> automatically setup the modalias.
> 
> Also make charger_manager_id static as it is only used in this driver.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Thanks.

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>

> ---
>  drivers/power/charger-manager.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
> index 0378d01..88fd971 100644
> --- a/drivers/power/charger-manager.c
> +++ b/drivers/power/charger-manager.c
> @@ -974,10 +974,11 @@ static int __devexit charger_manager_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -const struct platform_device_id charger_manager_id[] = {
> +static const struct platform_device_id charger_manager_id[] = {
>  	{ "charger-manager", 0 },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(platform, charger_manager_id);
>  
>  static int cm_suspend_prepare(struct device *dev)
>  {
> @@ -1069,4 +1070,3 @@ module_exit(charger_manager_cleanup);
>  MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@...sung.com>");
>  MODULE_DESCRIPTION("Charger Manager");
>  MODULE_LICENSE("GPL");
> -MODULE_ALIAS("charger-manager");
> -- 
> 1.7.5.4
>