linux-kernel - Re: [PATCH v2] input/mc13783-ts: add pdata to set conversion delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120111173540.GC21047@core.coreip.homeip.net>
Date:	Wed, 11 Jan 2012 09:35:40 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Michael Thalmeier <michael.thalmeier@...e.at>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, michael@...lmeier.at
Subject: Re: [PATCH v2] input/mc13783-ts: add pdata to set conversion delay

On Wed, Jan 11, 2012 at 11:49:23AM +0100, Michael Thalmeier wrote:
>  
> +struct mc13xxx_ts_platform_data {
> +	/* Delay between Touchscreen polarization and ADC Conversion.
> +	 * Given in clock ticks of a 32 kHz clock which gives a granularity of
> +	 * about 30.5ms */
> +	char ato;
> +
> +#define MC13783_TS_ATO_FIRST 0
> +#define MC13783_TS_ATO_EACH  1
> +	/* Use the ATO delay only for the first conversion or for each one */
> +	char atox;
> +};


'char' for these 2 looks wrong, 2 u8, u8 and bool or int and bool would
be better.

Otherwise am OK with input bits.

Acked-by: Dmitry Torokhov <dtor@...l.ru>

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/