linux-kernel - Re: [PATCH 6/6] ahci: support the STA2X11 I/O Hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120111225748.3e80a52d@bob.linux.org.uk>
Date:	Wed, 11 Jan 2012 22:57:48 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	Alessandro Rubini <rubini@...dd.com>
Cc:	linux-kernel@...r.kernel.org, giancarlo.asnaghi@...com,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, jgarzik@...ox.com, inux-ide@...r.kernel.org
Subject: Re: [PATCH 6/6] ahci: support the STA2X11 I/O Hub

On Fri, 6 Jan 2012 13:33:39 +0100
Alessandro Rubini <rubini@...dd.com> wrote:

> The AHCI controller found in the STA2X11 chip uses BAR number 0
> instead of 5. Also, the chip's fixup code sets a special DMA mask
> for all of its PCI functions, and the mask must be preserved here.

The more I look at this aspect of it the more convinced I grow that you
should handle this in the DMA ops.

dma_supported will call ops->dma_supported which can in turn make its
own decisions and avoid driver hackery.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/