linux-kernel - Re: [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Jan 2012 02:22:51 -0800
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	Zac Storer <zac.3.14159@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>
Subject: Re: [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing
 coding style issues

On Thu, Jan 12, 2012 at 03:01:49AM -0500, Jean Delvare wrote:
> On Fri, 18 Nov 2011 10:35:01 +0100, Jean Delvare wrote:
> > On Fri, 18 Nov 2011 01:36:53 -0700, Zac Storer wrote:
> > > Fixed spacing coding style issues.
> > > 
> > > Signed-off-by: Zac Storer <zac.3.14159@...il.com>
> > > ---
> > >  drivers/hwmon/adm1031.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
> > > index 0683e6b..694392b 100644
> > > --- a/drivers/hwmon/adm1031.c
> > > +++ b/drivers/hwmon/adm1031.c
> > > @@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
> > >  			data->alarm &= 0xc0ff;
> > >  		}
> > >  
> > > -		for (chan=0; chan<(data->chip_type == adm1030 ? 1 : 2); chan++) {
> > > +		for (chan = 0; chan < (data->chip_type == adm1030 ? 1 : 2); chan++) {
> > >  			data->fan_div[chan] =
> > >  			    adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
> > >  			data->fan_min[chan] =
> > 
> > Err, you apparently did not understand my request. Please send _one_
> > patch fixing all the adm1031 coding style issues at once.
> 
> Zac, do you have an updated patch for me?
> 
Just sent you one, with Zac's patches merged into one and (almost) all other checkpatch issues
fixed as well.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/