linux-kernel - Re: [git pull] vfs pile 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1326368496.5195.4.camel@tucsk.pomaz.szeredi.hu>
Date:	Thu, 12 Jan 2012 12:41:36 +0100
From:	Miklos Szeredi <mszeredi@...e.cz>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Ted Ts'o <tytso@....edu>, Christoph Hellwig <hch@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
Subject: Re: [git pull] vfs pile 1

On Wed, 2012-01-11 at 16:19 +0000, Al Viro wrote:

> Looking at the callers, I'm not sure we want that warning in set_nlink()
> at all, rate-limited or not.  Note that it can trigger on the things
> like stale NFS fhandle coming in for something that had been deleted
> a while ago - IOW, it's neither a kernel bug nor fs corruption.
> inc_nlink - sure, that might catch real bugs, drop_nlink - definitely,
> but this...

Patch follows.

Thanks,
Miklos
----

Subject: vfs: remove printk from set_nlink()

From: Miklos Szeredi <mszeredi@...e.cz>

Don't log a message for set_nlink(0).

Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
---
 fs/inode.c |    3 ---
 1 file changed, 3 deletions(-)

Index: linux-2.6/fs/inode.c
===================================================================
--- linux-2.6.orig/fs/inode.c	2012-01-11 10:55:00.000000000 +0100
+++ linux-2.6/fs/inode.c	2012-01-12 12:32:44.000000000 +0100
@@ -322,9 +322,6 @@ EXPORT_SYMBOL(clear_nlink);
 void set_nlink(struct inode *inode, unsigned int nlink)
 {
 	if (!nlink) {
-		printk_ratelimited(KERN_INFO
-			"set_nlink() clearing i_nlink on %s inode %li\n",
-			inode->i_sb->s_type->name, inode->i_ino);
 		clear_nlink(inode);
 	} else {
 		/* Yes, some filesystems do change nlink from zero to one */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/