linux-kernel - Re: [PATCH] mm: __count_immobile_pages make sure the node is online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120112123555.GF1042@tiehlicka.suse.cz>
Date:	Thu, 12 Jan 2012 13:35:55 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	Mel Gorman <mgorman@...e.de>
Cc:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	David Rientjes <rientjes@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: [PATCH] mm: __count_immobile_pages make sure the node is online

On Thu 12-01-12 11:14:15, Mel Gorman wrote:
> On Thu, Jan 12, 2012 at 11:05:21AM +0100, Michal Hocko wrote:
> > From 39de8df13532150fc4518dad0cb3f6fd88745b8a Mon Sep 17 00:00:00 2001
> > From: Michal Hocko <mhocko@...e.cz>
> > Date: Thu, 12 Jan 2012 10:19:04 +0100
> > Subject: [PATCH] mm: __count_immobile_pages make sure the node is online
> > 
> > page_zone requires to have an online node otherwise we are accessing
> > NULL NODE_DATA. This is not an issue at the moment because node_zones
> > are located at the structure beginning but this might change in the
> > future so better be careful about that.
> > 
> > Signed-off-by: Michal Hocko <mhocko@...e.cz>
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> 
> Acked-by: Mel Gorman <mgorman@...e.de>

Thanks

> Be aware that this is not the version picked up by Andrew. It would
> not hurt to resend as V2 with a changelog and a note saying it replaces
> mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch in mmotm.
> This is just in case the wrong one gets merged due to this thread
> getting lost in the noise of Andrew's inbox.

I guess that both of them should be merged. This one as a follow up fix.
That's why I made it separate and didn't repost the whole patch.
The original patch is much more obvious why it fixes the issue this one
is to have everything clear.
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/