linux-kernel - RE: [PATCH] efi: Avoid sysfs spew on reboot and panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5C4C569E8A4B9B42A84A977CF070A35B2C583942D2@USINDEVS01.corp.hds.com>
Date:	Thu, 12 Jan 2012 13:33:40 -0500
From:	Seiji Aguchi <seiji.aguchi@....com>
To:	Chen Gong <gong.chen@...ux.intel.com>,
	Matthew Garrett <mjg@...hat.com>
CC:	"tony.luck@...el.com" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mikew@...gle.com" <mikew@...gle.com>
Subject: RE: [PATCH] efi: Avoid sysfs spew on reboot and panic


>>>>>>   	mutex_lock(&psinfo->buf_mutex);
>>>>>>   	memcpy(psinfo->buf, buf, size);
>>>>>> -	id = psinfo->write(type, 0, size, psinfo);
>>>>>> +	id = psinfo->write(type, 0, KMSG_DUMP_UNKNOWN, size, psinfo);
>>>>>
>>>>> I can't say it is wrong because no real caller for this function, but I can't
>>>>> say it is right, yet. KMSG_DUMP_UNKNOWN here looks too arbirary. Do you have
>>>>> any reason to use this type here ?
>>>>
>>>> If a function calls pstore_write() directly then we have no type to
>>>> associate with it. It seems worth making this explicit.
>>>
>>> Yep, that's the point. We hope to get a more reasonable method to do it, not
>>> any assumption.
>>
>> I'm afraid I don't understand. Could you give an example of how you
>> think this should look?
>>
>If you insist on your design, I prefer deleting the function pstore_write before
>applying your patch. We all know no real users to call this function,
>every backend will register Its own callback, so this function is useless at all.

Matthew,

Do you plan to resend this patch?
Your patch will be accepted if you resend it,
because pstore_write() has been deleted by Kees.

Seiji