linux-kernel - Re: [PATCH 2/4] drivers/scsi/lpfc/lpfc_sli.c: convert GFP_KERNEL to GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1201122108320.25187@pl-59034.rocq.inria.fr>
Date:	Thu, 12 Jan 2012 21:08:52 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	James Smart <james.smart@...lex.com>
cc:	Julia Lawall <Julia.Lawall@...6.fr>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] drivers/scsi/lpfc/lpfc_sli.c: convert GFP_KERNEL to
 GFP_ATOMIC

On Thu, 12 Jan 2012, James Smart wrote:

> Julia,
>
> We actually do not want any ATOMIC allocations if we can avoid them.  We 
> reworked the calling sequence to deal with the locks being held. The change 
> will be in the next patch set.
>
> As such - Nack on the patch.

No problem.  It was more a bug report than a real patch.

thanks,
julia

> -- james s
>
>
>
> On 1/9/2012 4:40 AM, Julia Lawall wrote:
>> From: Julia Lawall<julia.lawall@...6.fr>
>> 
>> The function is called with locks held and thus should not use GFP_KERNEL.
>> 
>> The semantic patch that makes this report is available
>> in scripts/coccinelle/locks/call_kern.cocci.
>> 
>> More information about semantic patching is available at
>> http://coccinelle.lip6.fr/
>> 
>> Signed-off-by: Julia Lawall<julia.lawall@...6.fr>
>> 
>> ---
>>   drivers/scsi/lpfc/lpfc_sli.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
>> index 23a2759..622d24f 100644
>> --- a/drivers/scsi/lpfc/lpfc_sli.c
>> +++ b/drivers/scsi/lpfc/lpfc_sli.c
>> @@ -601,7 +601,7 @@ __lpfc_set_rrq_active(struct lpfc_hba *phba, struct 
>> lpfc_nodelist *ndlp,
>>   	if (test_and_set_bit(xritag, ndlp->active_rrqs.xri_bitmap))
>>   		goto out;
>> 
>> -	rrq = mempool_alloc(phba->rrq_pool, GFP_KERNEL);
>> +	rrq = mempool_alloc(phba->rrq_pool, GFP_ATOMIC);
>>   	if (rrq) {
>>   		rrq->send_rrq = send_rrq;
>>   		rrq->xritag = xritag;
>> 
>> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/