linux-kernel - Re: [PATCH] fs: Fix mod_timer crash when removing USB sticks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGagf4fNhiL9RDsAOk278K5iovg72nvT6ePCN0_18bHOh4d1aA@mail.gmail.com>
Date:	Thu, 12 Jan 2012 17:11:54 -0500
From:	Theodore Tso <tytso@...gle.com>
To:	Mandeep Singh Baines <msb@...omium.org>
Cc:	Greg KH <greg@...ah.com>, Paul Taysom <taysom@...omium.org>,
	Paul Taysom <taysom@...gle.com>,
	Olof Johansson <olofj@...omium.org>,
	Jens Axboe <axboe@...nel.dk>, Andrew Morton <akpm@...gle.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs: Fix mod_timer crash when removing USB sticks

On Thu, Jan 12, 2012 at 4:53 PM, Mandeep Singh Baines <msb@...omium.org> wrote:
>
> What is the conventional way of doing this? There is a lot of good
> data in the bug report which might be useful to reviewers. We
> couldn't find a de-facto way of referencing the downstream bug database
> so we just made up a new field. Sorry. We'll use the correct
> field name next time.

There isn't a "correct field name", since it hasn't been standardized.
I can tell you as an the ext4 maintainer, I've put things like:

Addresses-Redhat-Bugzilla: <Bugzilla #>

or

Addresses-Debian-Bug: <debian-bug-number>

etc. in commit messages.  I usually put them before the signed-off-block,
i.e, like this:

--------
ext4: a simple commit

This is the longer commit description, blah, blah, blah.

Addresses-Redhat-Bugzilla: 12345

Signed-off-by: Eric Sandeen <....@...hat.com>
Signed-off-by: Theodore Ts'o <tytso@....edu>
-----------

There is some disagreement about whether it's useful to do this
for bugzilla entries which are not publically available (i.e., protected
Enterprise Linux bugzillas which have customer information and
thus are restricted access, or internal Company bug numbers).

My personal take on this matter is that if an engineer from a
particular company has taken the time and effort to contribute
a bug that fixes a bug that they had seen internally, and they
include an internal bug number, it's presumably to make it easier
to track when a particular commit fixing a bug that they really
care about has hit upstream.  It costs me very little to keep
the bug tracker reference, even if I don't have personal access
to it, and given the code contributor has helped me by submitting
a bug fix, it's nice to be able to do a little something nice in
return.  The extra line doesn't really bloat the "git log" output
by all that much.

Others, including Greg K-H, think it's a horrible thing to do,
and will reject commits on that basis.

So it all depends on which subsystem maintainer handles
your bug.....  at the end, it's up to the maintainer.  I've never
had Linus complain to me because the commits that I ask him
to pull might include "Google-Bug-Id: 12345" lines in the commit
description.

-- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/