linux-kernel - Re: [PATCH 1/2] x86, amd: factor out MMCONFIG discovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1326351173.2741.3.camel@edumazet-laptop>
Date:	Thu, 12 Jan 2012 07:52:53 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, stable@...nel.org#2.6.34+,
	Borislav Petkov <borislav.petkov@....com>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	Yinghai Lu <yinghai@...nel.org>, Len Brown <lenb@...nel.org>
Subject: Re: [PATCH 1/2] x86, amd: factor out MMCONFIG discovery

Le jeudi 05 janvier 2012 à 14:27 -0700, Bjorn Helgaas a écrit :
> This factors out the AMD native MMCONFIG discovery so we can use it
> outside amd_bus.c.
> 
> amd_bus.c reads AMD MSRs so it can remove the MMCONFIG area from the
> PCI resources.  We may also need the MMCONFIG information to work
> around BIOS defects in the ACPI MCFG table.
> 
> Cc: Borislav Petkov <borislav.petkov@....com>
> Cc: Yinghai Lu <yinghai@...nel.org>
> Cc: stable@...nel.org       # 2.6.34+
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> ---
>  arch/x86/include/asm/amd_nb.h |    2 ++
>  arch/x86/kernel/amd_nb.c      |   31 ++++++++++++++++++++++++++++++
>  arch/x86/pci/amd_bus.c        |   42 +++++++++++------------------------------
>  3 files changed, 44 insertions(+), 31 deletions(-)

>  /**
> @@ -85,6 +57,9 @@ static int __init early_fill_mp_bus_info(void)
>  	u64 val;
>  	u32 address;
>  	bool found;
> +	struct resource fam10h_mmconf_res, *fam10h_mmconf;
> +	u64 fam10h_mmconf_start;
> +	u64 fam10h_mmconf_end;
>  
>  	if (!early_pci_allowed())
>  		return -1;
> @@ -211,12 +186,17 @@ static int __init early_fill_mp_bus_info(void)
>  		subtract_range(range, RANGE_NUM, 0, end);
>  
>  	/* get mmconfig */
> -	get_pci_mmcfg_amd_fam10h_range();
> +	fam10h_mmconf = amd_get_mmconfig_range(&fam10h_mmconf_res);
>  	/* need to take out mmconf range */

This adds following link error if "# CONFIG_CPU_SUP_AMD is not set"

  LD      .tmp_vmlinux1
arch/x86/pci/built-in.o: In function `early_fill_mp_bus_info':
/opt/src/linux/arch/x86/pci/amd_bus.c:189: undefined reference to
`amd_get_mmconfig_range'
make: *** [.tmp_vmlinux1] Error 1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/