linux-kernel - Re: [PATCH] backlight: Return proper error in l4f00242t03_probe if regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1326448850.3123.2.camel@realization>
Date:	Fri, 13 Jan 2012 11:00:50 +0100
From:	Alberto Panizzo <maramaopercheseimorto@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] backlight: Return proper error in l4f00242t03_probe if
 regulator_get fails

Hi Axel,

On Fri, 2012-01-13 at 17:00 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/video/backlight/l4f00242t03.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> index fae421a..6022b67 100644
> --- a/drivers/video/backlight/l4f00242t03.c
> +++ b/drivers/video/backlight/l4f00242t03.c
> @@ -190,6 +190,7 @@ static int __devinit l4f00242t03_probe(struct spi_device *spi)
>  
>  	priv->io_reg = regulator_get(&spi->dev, "vdd");
>  	if (IS_ERR(priv->io_reg)) {
> +		ret = PTR_ERR(priv->io_reg);
>  		dev_err(&spi->dev, "%s: Unable to get the IO regulator\n",
>  		       __func__);
>  		goto err3;
> @@ -197,6 +198,7 @@ static int __devinit l4f00242t03_probe(struct spi_device *spi)
>  
>  	priv->core_reg = regulator_get(&spi->dev, "vcore");
>  	if (IS_ERR(priv->core_reg)) {
> +		ret = PTR_ERR(priv->core_reg);
>  		dev_err(&spi->dev, "%s: Unable to get the core regulator\n",
>  		       __func__);
>  		goto err4;

Of course, I totally missed them..

Acked-by: Alberto Panizzo <alberto@...rulasolutions.com>

Thank you,
Alberto


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/