linux-kernel - Re: [PATCH] USB: EHCI: Don't use NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Jan 2012 12:27:22 +0100
From:	Michal Simek <michal.simek@...alogix.com>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	Alan Stern <stern@...land.harvard.edu>,
	Michal Simek <monstr@...str.eu>, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver

Alan Stern wrote:
> On Thu, 12 Jan 2012, Michal Simek wrote:
> 
>> Drivers shouldn't use NO_IRQ. This driver is used
>> by Microblaze and PPC. PPC defines NO_IRQ as 0
>> and Microblaze has removed it.
>>
>> Signed-off-by: Michal Simek <monstr@...str.eu>
>> CC: Alan Stern <stern@...land.harvard.edu>
>> CC: Greg Kroah-Hartman <gregkh@...e.de>
>> CC: Grant Likely <grant.likely@...retlab.ca>
>> CC: linux-usb@...r.kernel.org
>> CC: devicetree-discuss@...ts.ozlabs.org
>> ---
>>  drivers/usb/host/ehci-xilinx-of.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
>> index 32793ce..9c2cc46 100644
>> --- a/drivers/usb/host/ehci-xilinx-of.c
>> +++ b/drivers/usb/host/ehci-xilinx-of.c
>> @@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op)
>>  	}
>>  
>>  	irq = irq_of_parse_and_map(dn, 0);
>> -	if (irq == NO_IRQ) {
>> +	if (!irq) {
>>  		printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);
>>  		rv = -EBUSY;
>>  		goto err_irq;
> 
> Acked-by: Alan Stern <stern@...land.harvard.edu>

Thanks Alan.

I have seen that Grant sent the same patch to lkml too.
Here is the thread: http://lkml.org/lkml/2012/1/11/342

Grant: How fast do you think you are able to merge your patches?

Currently I have remove NO_IRQ from Microblaze and we use this driver which
means that driver compilation failed right now. That's why I would like to fix asap.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/