linux-kernel - Re: autofs4 hung task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Jan 2012 13:02:18 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Ian Kent <raven@...maw.net>
Cc:	Dave Airlie <airlied@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Al Viro <viro@....linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: autofs4 hung task

On Fri, Jan 13, 2012 at 08:44:17PM +0800, Ian Kent wrote:
> On Fri, 2012-01-13 at 10:26 +0000, Dave Airlie wrote:
> > Hi guys,
> > 
> > I booted Linus master kernel this morning (I was being brave and
> > basing some fixes on it), however it hung on boot and the stuck task
> > timer went off in autofs4 waiting on a mutex.
> > 
> > I got a picture with my phone attached.
> 
> Thanks Dave, an obvious mistake I missed in a recent commit by the look
> of it.
> 
> Ian

Grr...  Note to self: do git status *and* git stash show -p before git push.
Nothing like "WTF?  I'd fixed that braino" feeling ;-/

mutex_lock misspelled as mutex_unlock

Buggered-in: commit d668dc56631da067540b2494d2a1f29ff7b5f15a
Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
---
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 9ef5b29..da8876d 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -76,7 +76,7 @@ static int autofs4_write(struct autofs_sb_info *sbi,
 		data += wr;
 		bytes -= wr;
 	}
-	mutex_lock(&sbi->pipe_mutex);
+	mutex_unlock(&sbi->pipe_mutex);
 
 	set_fs(fs);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/