[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7vaa5rzaax.fsf_-_@alter.siamese.dyndns.org>
Date: Fri, 13 Jan 2012 11:12:22 -0800
From: Junio C Hamano <gitster@...ox.com>
To: Paul Gortmaker <paul.gortmaker@...driver.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Mark Brown <broonie@...nsource.wolfsonmicro.com>,
Liam Girdwood <lrg@...com>, <linux-kernel@...r.kernel.org>,
Git Mailing List <git@...r.kernel.org>
Subject: Re: [PATCH] merge: Make merge strategy message follow the diffstat
Paul Gortmaker <paul.gortmaker@...driver.com> writes:
> By moving the message after the diffstat, there is a better chance that
> people will be aware they've done a pointless merge commit.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
I think the goal of the change may be worthy, but a few points:
- What does "automsg" mean? Is "auto" in contrast to "manual"? Even
better, wouldn't it be far simpler to just use
if (msg && verbosity >= 0)
printf("%s\n", msg);
and get rid of this mysteriously named variable altogether?
- Wouldn't it make more sense to move "No merge message -- not updating
HEAD" also to the end?
- After applying this patch, does the tests still pass?
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists