linux-kernel - Re: [PATCH 1/6 v2] usb/gadget/pch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANKRQngF4nedC9KCyBV0aHf69Xg1ssb0DtYsNMAVnDfmN=k88g@mail.gmail.com>
Date:	Fri, 13 Jan 2012 13:12:44 +0900
From:	Tomoya MORINAGA <tomoya.rohm@...il.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	Felipe Balbi <balbi@...com>, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	qi.wang@...el.com, yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com
Subject: Re: [PATCH 1/6 v2] usb/gadget/pch_udc: Fix disconnect issue

Hi Sergei

2012/1/12 Sergei Shtylyov <sshtylyov@...sta.com>:
>> CAUSE:
>> When the driver calls dev->driver->disconnect(), it is not calling
>> spinlock().
>
>
>   spin_unlock(), you mean?

It means that there is not the following sentence in the previous source.
I think this is a cause of system freeze.
> +               spin_unlock(&dev->lock);
> +               spin_lock(&dev->lock);

I correct myself below.
CAUSE:
The driver calls dev->driver->disconnect() without calling
spin_unlock(&dev->lock).

thanks,
tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/