| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 Jan 2012 21:18:56 +0100 From: Jean Delvare <khali@...ux-fr.org> To: Alex Rio <scasbyte@...il.com> Cc: guenter.roeck@...csson.com, linux-kernel@...r.kernel.org, Rodolfo Giometti <giometti@...ux.it> Subject: Re: [RFC][PATCH 2/2] hwmon: (w83627ehf) Add GPIO port 3 functionality On Fri, 13 Jan 2012 19:39:56 -0600, Alex Rio wrote: > The w83627ehf chip has 5 GPIO ports, currently none of them is supported. > This patch adds the GPIO port 3 driver with the following functions: > set/get pin values, direction_in/out, set_debounce. > The values are also available to the userspace (if requiered) > in the path /sys/class/gpio by using the export/unexport functions. > Please look at the REVISIT comment, this is the main reason of the RFC, > suggestions will be highly appreciated. > > Signed-off-by: Alex Rio <scasbyte@...il.com> > --- > drivers/hwmon/w83627ehf.c | 188 +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 188 insertions(+), 0 deletions(-) This is calling for a MFD driver for these chips. This was proposed in the past, BTW, but never followed up: http://lists.lm-sensors.org/pipermail/lm-sensors/2010-February/027795.html Putting everything in the current driver is not going to be accepted. It certainly looks pleasant because it's a more simple approach, but the result would be a complex and unmaintainable driver. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists